Thanks for the fix!

@XYenon can you take a look at this PR?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3663

I would prefer to see plugin support in pkgs/by-name/ya/yazi/package.nix, modules should be kind of last resort IMO. The module could keep the extensions but the implementation should live in the wrapper.
It would makes the features accessible outside of nixos (includign home-manager)

Do you want to replace the module with a wrapper? Why is a wrapper preferred? I thought the wrapper will just become a mess. Those args in the wrapper can't be documented and discovered and no one knows how to use them without reading the code (I have seen enough examples). HM should implement their own module with plugins from nixpkgs.

Do you want to replace the module with a wrapper?

Not necessarily, we can have both if you maintain the module.

Why is a wrapper preferred?

Because it can be used outside nixos.

Those args in the wrapper can't be documented and discovered and no one knows how to use them without reading the code

says who ? of course they can be documented, just look at the nixpkgs documentation. Not only that but it's a lot easier to test a wrapper than a module.

says who ? of course they can be documented, just look at the nixpkgs documentation. Not only that but it's a lot easier to test a wrapper than a module.

Right, the only problem is that only few of them are documented because it's not generated automatically.

Because it can be used outside nixos.

Do you have any idea how to implement it? I thought we have to set YAZI_CONFIG_HOME in the wrapper and this overrides the default config files. So if the plugins are installed with the wrapper then the config also needs to be set with the wrapper. And this module will become a wrapper of the wrapper? Or a generator of the config home directory?

I thought we have to set YAZI_CONFIG_HOME in the wrapper and this overrides the default config files. So if the plugins are installed with the wrapper then the config also needs to be set with the wrapper.

This could be seen as an advantage, i.e, you get a pure config. but I recognize this can be a bother. Isn't it the same with this PR ? aka if you set files in YAZI_CONFIG_HOME = /etc/yazi then yazi will ignore the files in $XDG_CONFIG_HOME/yazi ?

There is a similar issue with the neovim wrapper.
The wrapper could (in impure mode, if we ever want that) generate an init.lua file that chain loads the one in $XDG_CONFIG_HOME ?

aka if you set files in YAZI_CONFIG_HOME = /etc/yazi then yazi will ignore the files in $XDG_CONFIG_HOME/yazi ?

Yazi by default only loads the config files in home.

The wrapper could (in impure mode, if we ever want that) generate an init.lua file that chain loads the one in $XDG_CONFIG_HOME ?

I don't think that yazi can load a config file in a config file...

OK, I know how to do that now.

I find a stupid problem. In fact I don't use the wrapper at all because I don't use those tools in the annoying wrapper. If I use the wrapper I have to set all of them to false. If the config is added to the wrapper I have to use the wrapper. This provide no benefits to me. So I add another option to disable all of them.

@teto Is there anything I can do? :)